Re: [PATCH 3/3] iio: chemical: scd30: make command lookup table const

[Maxwell Doose]

On Sun, May 10, 2026 at 2:59 AM Stepan Ionichev <sozdayvek@xxxxxxxxx> wrote:
>
> On Sun, 10 May 2026, Maxwell Doose wrote:
> > I'm curious, are you having AI do your reviews?
>
> English is not my native language, so I use AI to help with phrasing
> and to learn kernel review style. The technical analysis I do myself
> -- for this patch I checked via grep that scd30_i2c_cmd_lookup_tbl[]
> is only read (one read site in scd30_i2c_command() via
> put_unaligned_be16, no writes), which is what supports the const
> change being correct.
>

Thanks for confirming, just wanted to check since some of the phrasing
in your review did seem very AI-like.

>
> Happy to follow whatever disclosure norm the iio community prefers.
>

Typically reviews end up being one-liners (e.g., Reviewed-by: name
<email>) and that ends up being the whole message, sometimes reviewers
and maintainers will have inline comments. Obviously you don't have to
follow those norms but that's just what usually ends up happening.

best regards,
max

> Stepan