Re: [PATCH v2] iio: adc: ti-ads1298: Fix incorrect timeout comment
From: Andy Shevchenko
Date: Sun May 10 2026 - 06:16:55 EST
On Sun, May 10, 2026 at 11:45:30AM +0300, Md Shofiqul Islam wrote:
> At the lowest supported data rate of 250Hz, one conversion period is
> 4ms, not 40ms. The 50ms timeout is deliberately conservative to allow
> for kernel scheduling latency, which can be significant under load or
> on slow machines.
>
> Fix the comment to state the correct conversion time, use "lowest sample
> rate" for clarity, and explain that the extra margin exists to absorb
> scheduling latency so that no one is tempted to shrink the timeout to
> match the conversion period.
...
> - /* Cannot take longer than 40ms (250Hz) */
> + /* One conversion takes at most 4ms at the lowest sample rate (250Hz).
> + * Use 50ms to allow for kernel scheduling latency.
> + */
/*
* This is wrong style of multi-line comments in the IIO
* subsystem. Use this example on how to fix it.
*/
--
With Best Regards,
Andy Shevchenko