Re: [PATCH v1 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI

[Mark Brown]

On Sat, May 09, 2026 at 07:37:26AM +0530, Praveen Talari wrote:

> Could you also please review the changes made in spi.c ?
> I would appreciate any feedback or suggestions you may have.

Please just sumbmit normal patches instead of sending partial patches in
reply to another thread unless something is really unclear.

> @@ -1658,6 +1658,11 @@ static int spi_transfer_one_message(struct
> spi_controller *ctlr,
> 
>                 trace_spi_transfer_stop(msg, xfer);
> 
> +               if (spi_valid_txbuf(msg, xfer))
> +                       trace_spi_tx_data(msg->spi, xfer->tx_buf,
> xfer->len);
> +               if (spi_valid_rxbuf(msg, xfer))
> +                       trace_spi_rx_data(msg->spi, xfer->rx_buf,
> xfer->len);

It feels like it'd be more helpful to log the transmit data before we do
the send.

Attachment: signature.asc
Description: PGP signature