Re: [PATCH net-next v3 2/2] KEYS: annotate struct user_key_payload with __counted_by

[Jarkko Sakkinen]

On Sun, May 10, 2026 at 05:12:13PM +0300, Jarkko Sakkinen wrote:
> On Sun, May 10, 2026 at 12:47:24PM +0200, Thorsten Blum wrote:
> > On Sat, May 09, 2026 at 02:24:01PM +0300, Jarkko Sakkinen wrote:
> > > On Mon, Apr 27, 2026 at 01:44:24PM +0200, Thorsten Blum wrote:
> > > > Add the __counted_by() compiler attribute to the flexible array member
> > > > 'data' to improve bounds checking via CONFIG_UBSAN_BOUNDS and
> > > > CONFIG_FORTIFY_SOURCE.
> > > > 
> > > > Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> > > 
> > > This is again a crippled commit message.
> > > 
> > > I.e. this requires either knowing, remembering and/or cross-referencing
> > > "bunch of" unrelated to keyring.
> > 
> > I kept the commit message short because it follows the same pattern as
> > many other __counted_by() patches that have been accepted across several
> > subsystems.
> > 
> > I'm not sure which part of the message you want expanded. Could you be
> > more specific?
> 
> "Describe your problem. Whether your patch is a one-line bug fix or 5000
> lines of a new feature, there must be an underlying problem that
> motivated you to do this work. Convince the reviewer that there is a
> problem worth fixing and that it makes sense for them to read past the
> first paragraph."
> 
> This is a direct quote from https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

And there's pretty good reasons to do this too as commit message is not
just a cover leter for a patch. It's also reminder in the commit log why
something was done.

BR, Jarkko