Re: [PATCH net-next 1/2] can: j1939: convert to getsockopt_iter

[Oleksij Rempel]

On Thu, May 07, 2026 at 02:34:47AM -0700, Breno Leitao wrote:
> Convert CAN J1939 socket's getsockopt implementation to use the new
> getsockopt_iter callback with sockopt_t.
> 
> Key changes:
> - Replace (char __user *optval, int __user *optlen) with sockopt_t *opt
> - Use opt->optlen for buffer length (input) and returned size (output)
> - Use copy_to_iter() instead of copy_to_user()
> - Restructure the chained if/else if (which depended on put_user() being
>   an expression) into a nested if/else block now that opt->optlen = len
>   is a statement
> - Add linux/uio.h for copy_to_iter()
> 
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>

LGTM, Thank you!

Acked-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

Best Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |