Re: [PATCH 7/7] ASoC: ti: omap-mcbsp: Simplify lock and resource handling
From: Bui Duc Phuc
Date: Mon May 11 2026 - 00:44:59 EST
Hi Mark, Jarkko,
Thank you for testing and for the feedback.
> This function now mixes scoped and goto based cleanup which cleanup.h
> warns us not to do - are you sure this is a good idea?
I also feel that this function is easier to read and understand if it is
left unchanged, without using __free(kfree) and guard.
However, while cleaning up the code and converting the whole TI
folder to use guard, this function became the only remaining one
not using the new style, which felt a bit inconsistent.
That is why I tried converting it as well.
If you think leaving this single function unchanged is not a problem,
then I will prepare a v2 keeping this function as-is without modifying it.
Best regards,
Phuc