Re: [PATCH v2 1/2] gpio: regmap: Support sparsed fixed direction
From: Michael Walle
Date: Mon May 11 2026 - 03:23:03 EST
Hi,
On Fri May 8, 2026 at 2:51 PM CEST, Linus Walleij wrote:
> On some regmapped GPIOs apparently only a sparser selection
> of the lines (not all) are actually fixed direction.
>
> Support this situation by adding an optional bitmap indicating
> which GPIOs are actually fixed direction and which are not.
Thanks, this patch looks good. But could we invert the logic and use
fixed_direction_mask as that feels more natural to me?
And for legacy reasons, so we don't have to change the drivers:
if (!fixed_direction_mask && fixed_direction_output)
fixed_direction_mask = ~1
Or we just go ahead and change the two drivers. Up to you.
-michael
Attachment:
signature.asc
Description: PGP signature