Re: [PATCH] iommu/amd: Explicitly bail from enable_iommus_vapic() when in legacy mode

From: Joerg Roedel

Date: Mon May 11 2026 - 03:39:53 EST


On Fri, Mar 14, 2025 at 08:09:28PM -0700, Sean Christopherson wrote:
> Bail early from enable_iommus_vapic() if IOMMUs are configured for either
> of the legacy modes, as it's absurdly difficult to see that
> iommu_ga_log_enable() is guaranteed to fail because iommu_init_ga_log()
> skips allocating the ga_log.
>
> Opportunistically have iommu_ga_log_enable() WARN if it's called without
> IOMMUs being configured to support AVIC/vAPIC.
>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> ---
> drivers/iommu/amd/init.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)

Applied, thanks.