Re: [PATCH v6 1/3] staging: octeon: ethernet-mem: replace pr_warn with dev_warn in free functions

[Greg KH]

On Mon, May 04, 2026 at 11:11:44PM +0530, Ayush Mukkanwar wrote:
> Add struct platform_device parameter to cvm_oct_free_hw_skbuff,
> cvm_oct_free_hw_memory and cvm_oct_mem_empty_fpa. Replace pr_warn
> calls with dev_warn, using &pdev->dev for device-aware logging.
> 
> Signed-off-by: Ayush Mukkanwar <ayushmukkanwar@xxxxxxxxx>
> ---
>  drivers/staging/octeon/ethernet-mem.c | 31 ++++++++++++++++-----------
>  drivers/staging/octeon/ethernet-mem.h |  5 ++++-
>  drivers/staging/octeon/ethernet.c     |  6 +++---
>  3 files changed, 25 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/octeon/ethernet-mem.c b/drivers/staging/octeon/ethernet-mem.c
> index 532594957ebc..11036c6eb36f 100644
> --- a/drivers/staging/octeon/ethernet-mem.c
> +++ b/drivers/staging/octeon/ethernet-mem.c
> @@ -5,6 +5,7 @@
>   * Copyright (c) 2003-2010 Cavium Networks
>   */
>  
> +#include <linux/platform_device.h>
>  #include <linux/kernel.h>
>  #include <linux/netdevice.h>
>  #include <linux/slab.h>
> @@ -40,11 +41,13 @@ static int cvm_oct_fill_hw_skbuff(int pool, int size, int elements)
>  
>  /**
>   * cvm_oct_free_hw_skbuff- free hardware pool skbuffs
> + * @pdev:      Platform device for logging

You are adding a line here, and then "fixing it" in patch 3/3 :(

Please just do it right the first time.

thanks,

greg k-h