Re: [PATCH v2 1/4] KVM: s390: Minor refactor of base/ext facility lists

[Janosch Frank]

On 2/26/26 13:49, Christoph Schlameuss wrote:
> From: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx>
>
> Directly use the size of the arrays instead of going through the
> indirection of kvm_s390_fac_size().
> Don't use magic number for the number of entries in the non hypervisor
> managed facility bit mask list.
> Make the constraint of that number on kvm_s390_fac_base obvious.
> Get rid of implicit double anding of stfle_fac_list.
>
> Signed-off-by: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx>
> Co-developed-by: Christoph Schlameuss <schlameuss@xxxxxxxxxxxxx>
> Signed-off-by: Christoph Schlameuss <schlameuss@xxxxxxxxxxxxx>

I strongly dislike the facility management code as a whole and this 
patch makes it a tiny bit better. At some point this should be polished 
but today is not the day, so onto the TODO pile it goes.

Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx>