Re: [PATCH v13 net-next 2/9] net/mlx5e: Reduce stack use reading PCIe congestion thresholds

From: Dragos Tatulea

Date: Mon May 11 2026 - 05:18:39 EST




On 11.05.26 05:39, Ratheesh Kannoth wrote:
> union devlink_param_value grew when U64 array parameters were added.
> Keeping union devlink_param_value val[4] in
> mlx5e_pcie_cong_get_thresh_config() exceeded the compiler's
> -Wframe-larger-than limit.
>
> Reuse one union: call devl_param_driverinit_value_get() once per
> MLX5 PCIe congestion threshold and assign each vu16 to the
> corresponding mlx5e_pcie_cong_thresh member.
>
> Signed-off-by: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>
> ---

Reviewed-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>

Thanks for your patch!
Dragos