Re: [PATCH] cgroup: Keep favordynmods enabled once per-threadgroup rwsem is active

[Guopeng Zhang]

在 2026/5/11 16:56, Tejun Heo 写道:
> Hello, Guopeng.
> 
> Thanks for the patch.
> 
> I don't think this is worth changing. The mechanism is one-way, so on a
> disable attempt show_options has to lie one way or the other: clear the flag
> and it reports nofavordynmods while per-threadgroup rwsem is still in effect,
> keep the flag and it reports favordynmods after the user asked to turn it
> off. The pr_warn_once is what actually tells the user what happened. Neither
> flag choice is meaningfully better, and the underlying ambiguity is out of
> scope to address here. Without a stronger justification I'd rather leave the
> existing behavior alone.
> 
Hi, Tejun.

Thanks for the explanation.

I see your point. After a disable attempt, either value of the visible
mount option can be misleading, and the warning is what tells the user the
actual state.

Please consider this patch withdrawn.

Thanks,
Guopeng

> Thanks.
> 
> --
> tejun