Re: [PATCH] iio: adc: ad7766: Update to use iio_push_to_buffers_with_ts()
From: Andy Shevchenko
Date: Mon May 11 2026 - 06:44:57 EST
On Sun, May 10, 2026 at 05:14:04PM -0500, Ethan Tidmore wrote:
> The old ABI function iio_push_to_buffers_with_timestamp() is no longer
> preferred due to it being inherently unsafe.
>
> Update to the current standard iio_push_to_buffers_with_ts().
Nice, but there is nothing about correctness of the change. This is quite
sensitive area which is ABI. Any breakage is a big deal. Have you studied
the case deeper? What are the contents of the buffers with the old one and
new one versus channels enabled? Is timestamp located in the same offset
in both cases?
--
With Best Regards,
Andy Shevchenko