Re: [PATCH v2 2/2] ALSA: firewire: Make use of ieee1394's .driver_data_ptr
From: Andy Shevchenko
Date: Mon May 11 2026 - 06:57:33 EST
On Mon, May 11, 2026 at 12:45:03PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Recently struct ieee1394_device_id gained a new member to store a pointer
> to driver data. Make use of that to get rid of a bunch of casts.
...
> - if (!entry->driver_data)
> + if (!entry->driver_data_ptr)
> detect_formats = snd_dice_stream_detect_current_formats;
> else
> - detect_formats = (snd_dice_detect_formats_t)entry->driver_data;
> + detect_formats = entry->driver_data_ptr;
While at it, it can be swapped for better readability
if (entry->driver_data_ptr)
detect_formats = entry->driver_data_ptr;
else
detect_formats = snd_dice_stream_detect_current_formats;
--
With Best Regards,
Andy Shevchenko