Re: [PATCH v2 2/3] dt-bindings: usb: add Rohm BM92TXX Type-C controller

From: Rob Herring

Date: Mon May 11 2026 - 08:36:25 EST


On Sun, May 10, 2026 at 2:46 PM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
>
>
> On Mon, 11 May 2026 01:32:10 +0700, Alexandre Hamamdjian wrote:
> > Add the device-tree binding documentation for the Rohm BM92TXX family
> > of USB Type-C and Power Delivery controllers. The device is controlled
> > over I2C and signals state changes through a dedicated interrupt line.
> >
> > Document the rohm,* properties consumed by the driver: the optional
> > VCONN-enable GPIO, the DisplayPort alternate-mode toggles
> > (rohm,dp-disable, rohm,dp-alerts-enable, rohm,dp-signal-toggle-on-resume,
> > rohm,dp-lanes), the suspend/dock tunables (rohm,led-static-on-suspend,
> > rohm,dock-power-limit-disable) and the four
> > rohm,pd-{5,9,12,15}v-current-limit-ma per-PDO charging current limits.
> > A graph port is required to link the controller to a USB role switch
> > consumer.
> >
> > Signed-off-by: Alexandre Hamamdjian <azkali.limited@xxxxxxxxx>
> > ---
> > .../devicetree/bindings/usb/rohm,bm92t.yaml | 128 +++++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 129 insertions(+)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rohm,bm92t.yaml: rohm,pd-5v-current-limit-ma: missing type definition
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rohm,bm92t.yaml: rohm,pd-9v-current-limit-ma: missing type definition
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rohm,bm92t.yaml: rohm,pd-12v-current-limit-ma: missing type definition
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rohm,bm92t.yaml: rohm,pd-15v-current-limit-ma: missing type definition

Use a standard unit suffix.

Rob