Re: [PATCH 2/2] pinctrl: cs42l43: Fix polarity on debounce

[Bartosz Golaszewski]

On Fri, 8 May 2026 16:34:53 +0200, Charles Keepax
<ckeepax@xxxxxxxxxxxxxxxxxxxxx> said:
> The debounce bit sets a bypass on the debounce rather than enabling it,
> as such the current polarity of the debounce is set incorrectly. Invert
> the polarity to correct this.
>
> Fixes: d5282a539297 ("pinctrl: cs42l43: Add support for the cs42l43")
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
> index 3cc1835206077..305233fc19876 100644
> --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
> +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
> @@ -343,7 +343,7 @@ static int cs42l43_pin_set_db(struct cs42l43_pin *priv, unsigned int pin,
>
>  	return regmap_update_bits(priv->regmap, CS42L43_GPIO_CTRL2,
>  				  CS42L43_GPIO1_DEGLITCH_BYP_MASK << pin,
> -				  !!us << pin);
> +				  !us << pin);
>  }
>
>  static int cs42l43_pin_config_get(struct pinctrl_dev *pctldev,
> --
> 2.47.3
>
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>