Re: [PATCH 1/1] checkpatch: Ignore <inttypes.h> format macros

[Simon Glass]

Hi Petr,

On Mon, 11 May 2026 at 06:12, Petr Vorel <pvorel@xxxxxxx> wrote:
>
> Constants from <inttypes.h> are used only in userspace tools, they are
> from ISO C99, let's don't report it:
>
>     arch/mips/boot/tools/relocs.c:572: CHECK: Avoid CamelCase: <PRIx32>
>     arch/s390/tools/relocs.c:52: CHECK: Avoid CamelCase: <PRIu64>
>     tools/testing/selftests/mm/vm_util.c:244: CHECK: Avoid CamelCase: <SCNu64>
>
> Signed-off-by: Petr Vorel <pvorel@xxxxxxx>
> ---
>  scripts/checkpatch.pl | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3727156e4ccad..4c7a952a418c0 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5940,6 +5940,8 @@ sub process {
>  #Ignore SI style variants like nS, mV and dB
>  #(ie: max_uV, regulator_min_uA_show, RANGE_mA_VALUE)
>                             $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ &&
> +#Ignore <inttypes.h> format macros (e.g. PRIu64, SCNu64)
> +                           $var !~ /^(?:PRI|SCN)[dioux][A-Z0-9]+$/ &&
>  #Ignore some three character SI units explicitly, like MiB and KHz
>                             $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) {
>                                 while ($var =~ m{\b($Ident)}g) {
> --
> 2.53.0
>

Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx>

How about adding X as well, since <inttypes.h> also defines
uppercase-hex variants like PRIX8

Regards,
Simon