Re: [patch V5 05/15] x86/irq: Suppress unlikely interrupt stats by default

[Thomas Gleixner]

On Thu, Apr 02 2026 at 12:39, Radu Rendec wrote:
>> -	inc_irq_stat(SPURIOUS);
>> +	irq_stat_inc_and_enable(IRQ_COUNT_SPURIOUS);
>
> This is just a matter of style but for symmetry with inc_irq_stat(), I
> would prepend '__' to the function name and create a wrapper macro that
> adds the 'IRQ_COUNT_' prefix.
>
> And for consistency (you also have inc_perf_irq_stat()) I would call it
> inc_and_enable_irq_stat().

I fundamentaly despise these constructs which do not have a proper name
space prefix. They make it just hard to grep for. Yes, inc_irq_stat()
exists already, but that does not mean we need to proliferate it.

Thanks,

        tglx