Re: [PATCH v4 2/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in dsi probe

[Luca Ceresoli]

On Thu, 30 Apr 2026 21:49:43 +0200, Osama Abdelkader <osama.abdelkader@xxxxxxxxx> wrote:
> diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
> index 553a1df4688d..b12cd2690474 100644
> --- a/drivers/gpu/drm/bridge/chipone-icn6211.c
> +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
> @@ -767,10 +765,7 @@ static int chipone_i2c_probe(struct i2c_client *client)
>  
>  static void chipone_dsi_remove(struct mipi_dsi_device *dsi)
>  {
> -	struct chipone *icn = mipi_dsi_get_drvdata(dsi);
> -
>  	mipi_dsi_detach(dsi);
> -	drm_bridge_remove(&icn->bridge);
>  }

A further improvement would be using devm_mipi_dsi_attach() so the entire
remove function can be dropped. If you want to to that, please do it as a
separate series, after this has been applied.

Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com