Re: [PATCH net v3 1/3] macsec: introduce dedicated workqueue for SA crypto cleanup
From: Jinliang Zheng
Date: Mon May 11 2026 - 10:57:59 EST
On Sun, 11 May 2026, Sabrina Dubroca wrote:
> > In hindsight, there is no actual ordering dependency between SA
> > cleanups, so a normal workqueue is sufficient here. Should I send
> > a v4 with that switched to alloc_workqueue()?
>
> It probably doesn't matter a lot, but since your cover letter
> mentions "unnecessary latency", switching to a regular workqueue
> would help avoid giving the wrong impression that the ordered
> variant is needed.
>
> Either way, the patch looks ok to me
>
> Reviewed-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>
Great, I'll switch to alloc_workqueue() in v4. Thanks a lot for
the review and the Reviewed-by!
Thanks,
Jinliang