Re: [PATCH] iio: adc: ad7793: replace usleep_range() with fsleep()

From: Jonathan Cameron

Date: Mon May 11 2026 - 11:04:17 EST


On Mon, 11 May 2026 16:21:39 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Mon, May 11, 2026 at 10:30:43AM +0500, Stepan Ionichev wrote:
> > The AD7792/AD7793 datasheet (Rev. B, page 25, RESET section)
> > says: "When a reset is initiated, the user must allow a period
> > of 500 us before accessing any of the on-chip registers."
> >
> > Use fsleep(500) instead of usleep_range(500, 2000). The 500 us
> > minimum stays the same; fsleep() picks the upper slack itself
> > (about +25% on a default config -- narrower than the original
> > 2000 us).
>
> > Add a code comment with the datasheet reference so the "why"
> > of the wait is visible at the call site.
>
> Unneeded detail in the commit message (it more appropriate
> to have this in the comment block, below '---' line). Up to
> Jonathan what to do with it.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>
I left the comment on the comment. Not needed perhaps but not
harmful either.