Re: [PATCH v2] s390: fix dead defaults for S390_MODULES_SANITY_TEST and S390_UNWIND_SELFTEST

[Alexander Gordeev]

On Sat, May 09, 2026 at 08:50:43PM +0100, Julian Braha wrote:
> These config options currently have unconditional defaults of 'n' from the
> def_tristate statement, which shadow the later default of
> 'KUNIT_ALL_TESTS', causing it to be dead code.

Please, note that it is Kconfig Language dead code, not kernel one.

> It looks to me like the commit 25d36a85c61b ("s390/test_unwind: convert to KUnit")
> added the KUNIT_ALL_TESTS default to S390_UNWIND_SELFTEST, but mistakenly
> didn't remove the previous 'n' default.
> 
> Then, the later commit 90c5318795ee ("s390/module: test loading modules with a lot of relocations")
> copied the Kconfig layout from S390_UNWIND_SELFTEST when adding the
> S390_MODULES_SANITY_TEST config option, without noticing the existing mistake.

Please, paraphrase the above paragraphs in imperative and honour the
line lengths.

Also, please add this patch and adjust the commit message so it looks
like a s390 selftests config cleanup.

[PATCH] "s390: include S390_KPROBES_SANITY_TEST with KUNIT_ALL_TESTS"
https://lore.kernel.org/linux-s390/20260323125118.1417455-1-julianbraha@xxxxxxxxx/


> This dead code was found by kconfirm, a static analysis tool for Kconfig.
> 
> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
> ---
> v2: remove Fixes tags
> Link to v1: https://lore.kernel.org/all/20260414215651.151228-1-julianbraha@xxxxxxxxx/

Thanks!