Re: [PATCH 1/1] perf tests data_validation: Fixup test header

[Ian Rogers]

On Mon, May 11, 2026 at 5:10 AM Arnaldo Carvalho de Melo
<arnaldo.melo@xxxxxxxxx> wrote:
>
> We made a mistake by having the SPDX comment in the second line, where
> 'perf test' shell support expects the test title, fix it.
>
> Now we can specify a substring and have that test selected:
>
>   root@number:~# perf test truncat
>    84: Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).: Ok
>   root@number:~# perf test -vv truncat
>    84: Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).:
>   --- start ---
>   test child forked, pid 62890
>   ---- end(0) ----
>    84: Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).: Ok
>   root@number:~#
>
> Fixes: 24be50a54cb38cb4 ("perf test: Add truncated perf.data robustness test")
> Cc: Ian Rogers <irogers@xxxxxxxxxx>
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

I plan to send a patch to improve how the test name is read from a
script. It is either that or continuing to spend time teaching my LLM
not to make checkpatch.pl happy and thereby break this. It seems
better that we just teach the code to skip lines containing SPDX.

Thanks,
Ian

> ---
>  tools/perf/tests/shell/data_validation.sh | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/data_validation.sh b/tools/perf/tests/shell/data_validation.sh
> index 649f71b6cdb93202..f8fcc4c0448b0c51 100755
> --- a/tools/perf/tests/shell/data_validation.sh
> +++ b/tools/perf/tests/shell/data_validation.sh
> @@ -1,7 +1,6 @@
>  #!/bin/bash
> +# Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).
>  # SPDX-License-Identifier: GPL-2.0
> -# Test that perf report handles truncated perf.data gracefully
> -# (no crash, no segfault — clean error exit).
>  #
>  # Exercises the bounds checking and minimum-size validation added
>  # by the perf-data-validation hardening series.
> --
> 2.54.0
>