Re: [PATCH 2/4] firmware: qcom: scm: use dev_err_probe() for dload address failure

[Mukesh Ojha]

On Thu, May 07, 2026 at 09:01:24AM -0500, Bjorn Andersson wrote:
> On Thu, May 07, 2026 at 01:37:18PM +0530, Mukesh Ojha wrote:
> > Replace the bare `return ret` after qcom_scm_find_dload_address() with
> 
> Describe a problem, not an action.

There is no problem here, It is just for consistancy and an extra log., Hence,
just the action.

> 
> Why is this patch part of this series? I don't see how it relate to
> "minidump SRAM destination support".

Was making a change after that line in the following patches, So,
thought of sending it part of the series.

> 
> Change looks reasonable.

Thanks.

> 
> Regards,
> Bjorn
> 
> > dev_err_probe() to produce a consistent, deferred-probe-aware error
> > message when the download-mode address cannot be resolved.
> > 
> > Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/firmware/qcom/qcom_scm.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> > index d9ee180388aa..f65b132004a5 100644
> > --- a/drivers/firmware/qcom/qcom_scm.c
> > +++ b/drivers/firmware/qcom/qcom_scm.c
> > @@ -2762,7 +2762,8 @@ static int qcom_scm_probe(struct platform_device *pdev)
> >  	scm->dev = &pdev->dev;
> >  	ret = qcom_scm_find_dload_address(&pdev->dev, &scm->dload_mode_addr);
> >  	if (ret < 0)
> > -		return ret;
> > +		return dev_err_probe(&pdev->dev, ret,
> > +				     "Failed to find download mode address\n");
> >  
> >  	mutex_init(&scm->scm_bw_lock);
> >  
> > -- 
> > 2.53.0
> > 

-- 
-Mukesh Ojha