Re: [PATCH net-next v2 1/9] dt-bindings: net: add onsemi's S2500 10BASE-T1S MACPHY

From: Andrew Lunn

Date: Mon May 11 2026 - 15:15:45 EST

> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethernet@0 {
> + compatible = "onnn,s2500";
> + reg = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&eth0_pins>;
> + interrupt-parent = <&gpio>;
> + interrupts = <25 2>;

IRQ_TYPE_EDGE_FALLING

But is edge correct? Should it be level?

And i hope this illustrates why you should use the defines.

Andrew