Re: [PATCH net-next v2 2/9] net: phy: ncn26000: bugfixes/improvements to NCN26000 PHY driver
From: Andrew Lunn
Date: Mon May 11 2026 - 15:21:28 EST
On Mon, May 11, 2026 at 06:19:04PM +0000, Selvamani Rajagopal wrote:
> Proprietary, noise immunity bit is set when PLCA is enabled
> Link status bit was wrong. Fixed now
> MAINTAINER's new email ID updated
Please don't mix multiple things in one patch.
> @@ -108,7 +130,7 @@ static irqreturn_t ncn26000_handle_interrupt(struct phy_device *phydev)
> ret = phy_read(phydev, NCN26000_REG_IRQ_STATUS);
>
> // check only link status changes
> - if (ret < 0 || (ret & NCN26000_REG_IRQ_STATUS) == 0)
> + if (ret < 0 || (ret & NCN26000_IRQ_LINKST_BIT) == 0)
If this is a fix, please base it on net, and add a Fixes: tag.
Andrew
---
pw-bot: cr