Re: [PATCH net-next v2 4/9] net: phy: ncn26000: Support for internal phy for S2500

[Andrew Lunn]

> +  /* NCN26000 PHY didn't have the default value */
> +	if (pdrv->phy_id == PHY_ID_NCN26000)


> +		PHY_ID_MATCH_MODEL(PHY_ID_S2500),

Since you are using PHY_ID_MATCH_MODEL(), you should use
phy_id_compare_model().

	Andrew