Re: [PATCH net-next v2 7/9] net: ethernet: oa_tc6: fix for minor issues

[Andrew Lunn]

> @@ -459,9 +459,7 @@ EXPORT_SYMBOL_GPL(oa_tc6_hwtstamp_ioctl);
>  /**
>   * Add vendor specific MDIO_MMD to OA TC6 MMS mapper value.
>   * @tc6: oa_tc6 struct.
> - * @mms: vendor defined MMS value.
> - *
> - * Return: 0 on success otherwise failed.
> + * @mms: vendor defined MMS value for VEND1 mdio device.

You just added this in a previous patch. Don't patch your own patch,
get it right the first time.

> @@ -701,7 +699,7 @@ static int oa_tc6_mdiobus_read(struct mii_bus *bus, int addr, int regnum)
>  {
>  	struct oa_tc6 *tc6 = bus->priv;
>  	u32 regval;
> -	bool ret;
> +	int ret;
>  
>  	ret = oa_tc6_read_register(tc6, OA_TC6_PHY_STD_REG_ADDR_BASE |
>  				   (regnum & OA_TC6_PHY_STD_REG_ADDR_MASK),
> @@ -864,7 +862,7 @@ static void oa_tc6_phy_exit(struct oa_tc6 *tc6)
>  	oa_tc6_mdiobus_unregister(tc6);
>  }

Please put this in a patch of its own, with a good commit
message. Lots of small patches, each with a good commit message.


>  
> -static int oa_tc6_read_status0(struct oa_tc6 *tc6)
> +static u32 oa_tc6_read_status0(struct oa_tc6 *tc6)
>  {
>  	u32 regval;
>  	int ret;

A patch of its own, and the commit message can explain why, because it
takes a bit of work to understand why.

	Andrew