Re: [PATCH] net: mention the convention for .ndo_setup_tc()
From: Jakub Kicinski
Date: Mon May 11 2026 - 20:32:13 EST
On Fri, 8 May 2026 05:40:51 +0800 David Yang wrote:
> qdisc_offload_dump_helper(), originated from commit 602f3baf2218
> ("net_sch: red: Add offload ability to RED qdisc"), is designed to that
>
> Whether RED is being offloaded is being determined every time dump
> action is being called because parent change of this qdisc could
> change its offload state but doesn't require any RED function to be
> called.
>
> and returning -EOPNOTSUPP (for dump queries) does not mean "I don't have
> any statistics", but "I don't offload this qdisc anymore". At least two
> existing drivers did it wrong, so it is worth mentioning.
Applied (with a minor tweak), thanks!