RE: [PATCH rtw-next v2 1/1] wifi: rtw89: usb: Support switching to USB 3 mode

[Ping-Ke Shih]

Devin Wittmayer <lucid_duck@xxxxxxxxxxxxx> wrote:
> From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>

[...]

> @@ -1027,6 +1032,35 @@ static void rtw89_usb_intf_deinit(struct rtw89_dev *rtwdev,
>         usb_set_intfdata(intf, NULL);
>  }
> 
> +static int rtw89_usb_switch_mode(struct rtw89_dev *rtwdev)
> +{
> +       struct rtw89_usb *rtwusb = rtw89_usb_priv(rtwdev);
> +
> +       if (!rtw89_switch_usb_mode)
> +               return 0;
> +
> +       /* No known USB 3 devices with this chip. */
> +       if (rtwdev->chip->chip_id == RTL8851B)
> +               return 0;

As commit message, only RTL8832BU and RTL8832CU were tested, and WiFi 7
was not neither. I'd give positive list instead.

> +
> +       if (rtwusb->udev->speed == USB_SPEED_SUPER)
> +               return 0;
> +
> +       rtw89_debug(rtwdev, RTW89_DBG_HCI, "%s: pad_ctrl2: %#x %#x\n",
> +                   __func__,
> +                   rtw89_read8(rtwdev, R_AX_PAD_CTRL2 + 1),
> +                   rtw89_read8(rtwdev, R_AX_PAD_CTRL2 + 2));
> +
> +       /* Already tried to switch but it's a USB 2 port. */
> +       if (rtw89_read8(rtwdev, R_AX_PAD_CTRL2 + 1) == USB_SWITCH_DELAY)
> +               return 0;
> +
> +       rtw89_write8(rtwdev, R_AX_PAD_CTRL2 + 1, USB_SWITCH_DELAY);
> +       rtw89_write8(rtwdev, R_AX_PAD_CTRL2 + 2, U2SWITCHU3);
> +
> +       return 1;
> +}
> +
>  int rtw89_usb_probe(struct usb_interface *intf,
>                     const struct usb_device_id *id)
>  {