RE: [PATCH net-next 01/15] net: enetc: switch VF primary MAC setter to PF ops for commonization
From: Wei Fang
Date: Mon May 11 2026 - 21:57:21 EST
> On Mon, May 11, 2026 at 04:07:51PM +0800, Wei Fang wrote:
> > Use pf->ops->set_si_primary_mac() instead of direct call to
> > enetc_pf_set_primary_mac_addr() in preparation for moving
> > enetc_msg_pf_set_vf_primary_mac_addr() to enetc-pf-common.
> >
> > This enables both ENETC v1 and v4 PF drivers to share the VF MAC
> > configuration interface. No functional change.
> >
> > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> > ---
> > drivers/net/ethernet/freescale/enetc/enetc_pf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> > b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> > index a12fd54a475f..9063255d8ca5 100644
> > --- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> > +++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> > @@ -497,7 +497,7 @@ static u16
> enetc_msg_pf_set_vf_primary_mac_addr(struct enetc_pf *pf,
> > dev_warn(dev, "Attempt to override PF set mac addr for VF%d\n",
> > vf_id);
> > else
> > - enetc_pf_set_primary_mac_addr(&pf->si->hw, vf_id + 1, addr);
> > + pf->ops->set_si_primary_mac(&pf->si->hw, vf_id + 1, addr);
>
> Doesn't enetc_set_si_hw_addr() exist as a wrapper around
> pf->ops->set_si_primary_mac()?
>
Yes, enetc_set_si_hw_addr() is the wrapper for
pf->ops->set_si_primary_mac().
I will export enetc_set_si_hw_addr() for enetc_pf.c to use.
> >
> > return ENETC_MSG_CMD_STATUS_OK;
> > }
> > --
> > 2.34.1
> >