Re: [PATCH] nvmem: layouts: onie-tlv: fix read_post_process assignment

[anis chali]

Please disregard this patch.

Le lun. 11 mai 2026 à 22:57, <chalianis1@xxxxxxxxx> a écrit :
>
> From: Chali Anis <chalianis1@xxxxxxxxx>
>
> Assign the onie_tlv_read_cb callback directly to
> read_post_process instead of calling it during assignment.
>
> The field expects a function pointer, not a function call.
>
> Fixes: d3c0d12f6474 ("nvmem: layouts: onie-tlv: Add new layout driver")
> Signed-off-by: Chali Anis <chalianis1@xxxxxxxxx>
> ---
>  drivers/nvmem/layouts/onie-tlv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/layouts/onie-tlv.c b/drivers/nvmem/layouts/onie-tlv.c
> index 0967a32319a2..0242f64fe713 100644
> --- a/drivers/nvmem/layouts/onie-tlv.c
> +++ b/drivers/nvmem/layouts/onie-tlv.c
> @@ -124,7 +124,7 @@ static int onie_tlv_add_cells(struct device *dev, struct nvmem_device *nvmem,
>                 cell.offset = hdr_len + offset + sizeof(tlv.type) + sizeof(tlv.len);
>                 cell.bytes = tlv.len;
>                 cell.np = of_get_child_by_name(layout, cell.name);
> -               cell.read_post_process = onie_tlv_read_cb(tlv.type, data + offset + sizeof(tlv));
> +               cell.read_post_process = onie_tlv_read_cb;
>
>                 ret = nvmem_add_one_cell(nvmem, &cell);
>                 if (ret) {