Re: [PATCH] atomisp: remove unused module parameter dbg_func

From: Andy Shevchenko

Date: Tue May 12 2026 - 00:27:11 EST


On Mon, May 11, 2026 at 10:32 PM Melih Emik <melihemik@xxxxxxxxxxx> wrote:
>
> atomisp_v4l2.c declared dbg_func as a module parameter to expose the
> CSS debug print switch at module load time.
>
> dbg_func remains as internal state for the CSS print environment, but
> no code depends on the module parameter registration. After this removal,
> git grep only finds the internal variable users and no module_param() or
> MODULE_PARM_DESC() entry for dbg_func.
>
> Remove the obsolete parameter while leaving the existing default debug
> print state unchanged.

While the direction is good, the patch is half-baked. Instead make
sure the similar infrastructure is available at runtime, exempli
gratia via trace events or dynamic debug.

--
With Best Regards,
Andy Shevchenko