Re: [PATCH 0/2] PCI: endpoint: pci-epf-{v}ntb: A couple of fixes

From: Krzysztof Wilczyński

Date: Tue May 12 2026 - 01:48:34 EST


Hello,

> These two fixes are flagged by Sashiko during the review of doorbell series:
> https://sashiko.dev/#/patchset/20260406155717.880246-1-den%40valinux.co.jp
>
> Manivannan Sadhasivam (2):
> PCI: endpoint: pci-epf-vntb: Add check to detect 'db_count' value of 0
> PCI: endpoint: pci-epf-ntb: Add check to detect 'db_count' value of 0
>
> drivers/pci/endpoint/functions/pci-epf-ntb.c | 15 +++++++++------
> drivers/pci/endpoint/functions/pci-epf-vntb.c | 9 +++------
> 2 files changed, 12 insertions(+), 12 deletions(-)

Might be out of scope, but since we removed one redundant "db_count"
variable already, perhaps we could also drop this one, too. Just to add
a small clean-up since we are touching this code already... Thoughts?

Looking at epf_ntb_db_mw_bar_init():

(...)

db_count = ntb->db_count;

for (bar = BAR_DB_MW1, i = 0; i < num_mws; bar++, i++) {
if (bar == BAR_DB_MW1) {
align = align ? align : 4;
size = db_count * align;
size = ALIGN(size, ntb->mws_size[i]);
ctrl = ntb_epc->reg;
ctrl->mw1_offset = size;
size += ntb->mws_size[i];
} else {
size = ntb->mws_size[i];
}

(...)
}

Thank you!

Krzysztof