Re: [PATCH v3 4/9] mm/memory: Batch set uffd-wp markers during zapping

[David Hildenbrand (Arm)]

>>
>> If we conditionally do something, what about while at it shorten it to:
>>
>> 	cont_install_uffd_wp_ptes()
> 
> Why "cont_"? Did you mean to say "cond" ("conditionally").

Yes, like cond_resched().

> 
>>
>> Also, less churn in this patch if you don't change pte->ptep
>>
>> (because if you do, you should then also do pteval->pte :) )
>>
>> So I'd just leave that as is in this patch.
> 
> So I'll change pte->ptep and pteval->pte because I hate pte pointers
> called pte : )

Yeah, me too, but it's all over the place happening ... :)

-- 
Cheers,

David