Re: [PATCH v1 1/2] staging: sm750fb: remove unused #include directives

[Greg Kroah-Hartman]

On Tue, May 12, 2026 at 10:32:31AM +0545, Chhabilal Dangal wrote:
> sm750_hw.c includes <asm/mtrr.h> under #ifdef CONFIG_MTRR, but no
> mtrr_add/mtrr_del calls exist in the file; the driver uses
> arch_phys_wc_add/arch_phys_wc_del in sm750.c instead.
> 
> sm750_hw.c, sm750_accel.c, and sm750_cursor.c all include
> <linux/platform_device.h>, but none use any platform device APIs.
> This is a PCI driver.

These are statements that don't really describe anything :(

> Remove these dead includes per the TODO item to refine the code
> and remove unused code.
> 
> Tested by building the full kernel and module with CONFIG_FB_SM750=m
> on x86_64:
>   make -j$(nproc)
>   make M=drivers/staging/sm750fb modules

You don't need to have these lines, it is assumed you test-built this.

> Signed-off-by: Chhabilal Dangal <yogeshdangal66@xxxxxxxxx>

You need a blank line before this line.

Also, your patches were not properly connected, please use a tool like
git send-email to send them out.

Also, you are doing multiple things in this patch, please, only one
logical thing per commit.

thanks,

greg k-h