Re: [PATCH] docs: reporting-issues: fix advice wording
From: Thorsten Leemhuis
Date: Tue May 12 2026 - 02:26:53 EST
On 5/12/26 03:51, Chen-Shi-Hong wrote:
> Replace "these advices" with "this advice" in
> Documentation/admin-guide/reporting-issues.rst.
Thx for this, fixing this is a good idea. It nevertheless makes me go
"hmmm...", as the wrongly executed and maybe not obvious enough original
intention of the author (disclaimer: me) was to make it a bit clearer
that "this advice" does not only mean the one advice right before it,
but all the pieces of advice in the paragraph. It would be great to
cover that while fixing it. "pieces of advice" maybe? Not sure. Maybe
somebody has a better idea. And maybe just ignore my nitpicking, guess
"this advice" just feels too easy to misinterpret from my point of view
as someone to whom English is a second language.
Ciao, Thorsten
> Signed-off-by: Chen-Shi-Hong <eric039eric@xxxxxxxxx>
> ---
> Documentation/admin-guide/reporting-issues.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
> index 16a66a1f1975..731865b5e8ff 100644
> --- a/Documentation/admin-guide/reporting-issues.rst
> +++ b/Documentation/admin-guide/reporting-issues.rst
> @@ -129,7 +129,7 @@ After these preparations you'll now enter the main part:
> situations; during the merge window that actually might be even the best
> approach, but in that development phase it can be an even better idea to
> suspend your efforts for a few days anyway. Whatever version you choose,
> - ideally use a 'vanilla' build. Ignoring these advices will dramatically
> + ideally use a 'vanilla' build. Ignoring this advice will dramatically
> increase the risk your report will be rejected or ignored.
>
> * Ensure the kernel you just installed does not 'taint' itself when
> @@ -795,7 +795,7 @@ Install a fresh kernel for testing
> situations; during the merge window that actually might be even the best
> approach, but in that development phase it can be an even better idea to
> suspend your efforts for a few days anyway. Whatever version you choose,
> - ideally use a 'vanilla' built. Ignoring these advices will dramatically
> + ideally use a 'vanilla' built. Ignoring this advice will dramatically
> increase the risk your report will be rejected or ignored.*
>
> As mentioned in the detailed explanation for the first step already: Like most
>
> base-commit: 5d6919055dec134de3c40167a490f33c74c12581
> prerequisite-patch-id: 1089bde9e188a84c873ff722a776bc107a6e8103