Re: [PATCH v2] staging: rtl8723bs: fix line length checks in rtw_cmd.c

From: Dan Carpenter

Date: Tue May 12 2026 - 03:28:04 EST


On Mon, May 11, 2026 at 08:31:15PM -0400, Noah Techoueyres wrote:
> Fix both block comments and assignment statements that exceed the
> 100-column limit to follow Linux guidelines for readability. Used
> intermediate pointers to fix assignment statements.
>

These are unrelated. Do it in two patches.

> Signed-off-by: Noah Techoueyres <noahtechoueyres@xxxxxxxxx>
> ---
> Changes in v2:
> - Replaced repeated struct access paths with an intermediate
> pointer to traffic_stat to resolve the 100-column limit.
>
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 38 ++++++++++++++----------
> 1 file changed, 23 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index c1185c25ed36..5c6999ac17f6 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1106,24 +1106,25 @@ static void collect_traffic_statistics(struct adapter *padapter)
> {
> struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter);
>
> + struct rtw_traffic_statistics *stat = &pdvobjpriv->traffic_stat;

Don't put a blank line in the middle of the declaration block.

regards,
dan carpenter