Re: [PATCH v2 8/9] exfat: add iomap direct I/O support

[Namjae Jeon]

On Tue, May 12, 2026 at 3:37 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> > +static int exfat_truncate(struct inode *inode)
> >  {
> >       struct super_block *sb = inode->i_sb;
> >       struct exfat_sb_info *sbi = EXFAT_SB(sb);
> > @@ -315,6 +315,8 @@ void exfat_truncate(struct inode *inode)
> >       inode->i_blocks = round_up(i_size_read(inode), sbi->cluster_size) >> 9;
> >  write_size:
> >       mutex_unlock(&sbi->s_lock);
> > +
> > +     return err;
>
> Allowing error returns here looks unrelated to iomap usage?
Yes, I'll split it out into a separate patch.

>
> > +     if (iov_iter_count(from)) {
> > +             loff_t offset, end;
> > +             ssize_t written;
> > +             int ret2;
>
>
> .. splitting this whole code block into a helper would be nice.
> And eventually it might be worth to lift it to iomap as we have
> a few open coded versions of it.
Okay, I will split it into a helper.
>
> > +out:
> > +     return ret;
> > +}
>
> Usuaully just directly returning instead of jumping to a label that
> returns is easier to follow.
Okay, I will update it.
>
> Otherwise this looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Thanks for the review!
>