Re: [PATCH v5 2/2] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS

[Stanislav Zaikin]

On 4/19/26 1:47 AM, Dmitry Baryshkov wrote:
> On Fri, Apr 17, 2026 at 10:47:49AM +0200, Stanislav Zaikin wrote:
> > Xiaomi 12 Lite 5G is a handset released in 2022
> >
> > This commit has the following features working:
> > - Display (with simple fb)
> > - Touchscreen
> > - UFS
> > - Power and volume buttons
> > - Pinctrl
> > - RPM Regulators
> > - Remoteprocs - wifi, bluetooth
> > - USB (Device Mode)
> >
> > Signed-off-by: Stanislav Zaikin <zstaseg@xxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/Makefile             |   1 +
> >   .../boot/dts/qcom/sm7325-xiaomi-taoyao.dts    | 907 ++++++++++++++++++
> >   2 files changed, 908 insertions(+)
> >   create mode 100644 arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts
> >
> > +
> > +&ipa {
> > +	qcom,gsi-loader = "self";
> > +	memory-region = <&ipa_fw_mem>;
>
> Could you please move these properties to SoC dtsi (as a separate
> commit).

Sure will do in v6.

> > +	firmware-name = "qcom/sm7325/xiaomi/taoyao/ipa_fws.mbn";
> > +
> > +	status = "okay";
> > +};
> > +
> > +
> > +&tlmm {
> > +	gpio-reserved-ranges = <48 4>, <56 4>;
>
> Could you please add a comment why they are reserved? I _assume_ that 48
> is NFC SE and 56 is fingerprint reader

I can add a comment like this (or you can suggest different wording):

/*
 * 48-51: presumably NFC SE
 * 56-59: presumably fingerprint reader
 */

If that works, I will add in v6.

Thanks for the review,

Best regards,
Stanislav