Re: [PATCH v10 2/9] revocable: Add KUnit test cases

From: Tzung-Bi Shih

Date: Tue May 12 2026 - 04:13:46 EST


On Mon, May 11, 2026 at 06:10:32AM -0700, Bartosz Golaszewski wrote:
> On Fri, 8 May 2026 12:54:41 +0200, Tzung-Bi Shih <tzungbi@xxxxxxxxxx> said:
> > diff --git a/drivers/base/revocable_test.c b/drivers/base/revocable_test.c
>
> Please move this under drivers/base/tests/ where the rest of kunit modules
> live and name it revocable-test.c for consistency with the existing ones.

Ack, I overlooked the folder. Will move the test to drivers/base/test/ and
rename it in the next version.

> > +#include <kunit/test.h>
>
> Add a newline here as do other kunit modules.

Ack, will fix it in the next version.