Re: [PATCH net-next v2 6/9] net: atlantic: implement AQC113 L2/L3/L4 RX filter management filter management management

[Paolo Abeni]

On 5/8/26 2:01 PM, sukhdeeps@xxxxxxxxxxx wrote:
> @@ -530,6 +580,35 @@ static int hw_atl2_hw_init_rx_path(struct aq_hw_s *self)
>  	return aq_hw_err_from_flags(self);
>  }
>  
> +static int hw_atl2_hw_mac_addr_set(struct aq_hw_s *self, const u8 *mac_addr)
> +{
> +	struct hw_atl2_priv *priv = self->priv;
> +	u32 location = priv->l2_filters_base_index;
> +	unsigned int h;
> +	unsigned int l;
> +	int err;

Minor nit: please respect the reverse christmas tree above (and elsewhere)

Side note: this patch is quite big, IMHO too much to be effectively
reviewed without relying entirely on automated tools, please try split
it into smaller chunks.

Also, when posting the next revision please on avoid send the patch in
reply to the previous iteration: it will foul both the tools and the
human behind them.

Finally please note that the patch subj contains repeated words, please
drop them.

/P