Re: [PATCH v3 4/7] PCI: dwc: Use common pci_host_common_link_train_delay() helper

From: Hans Zhang

Date: Tue May 12 2026 - 06:11:40 EST




On 5/12/26 15:14, Krzysztof Wilczyński wrote:
Hello,

- /*
- * As per PCIe r6.0, sec 6.6.1, a Downstream Port that supports Link
- * speeds greater than 5.0 GT/s, software must wait a minimum of 100 ms
- * after Link training completes before sending a Configuration Request.
- */
- if (pci->max_link_speed > 2)
- msleep(PCIE_RESET_CONFIG_WAIT_MS);
+ pci_host_common_link_train_delay(pci->max_link_speed);

This comment could move to the helper you added.

Hi Krzysztof,

Will add.

No need. Per Mani's feedback about macro being well documented.


Hi Krzysztof,

Okay.

Best regards,
Hans

Thank you nonetheless!

Krzysztof