Re: [PATCH] staging: Documentation: dds: replace frequencyY with frequency

From: Andy Shevchenko

Date: Tue May 12 2026 - 07:20:47 EST


On Mon, May 11, 2026 at 10:42:55PM +0530, Abinash Singh wrote:

> The documented frequencyY attribute naming is implementation

I'm lost here. What frequencyY? I don't see that in the patch.
I think this needs to be more specific. Can you rephrase?

> specific and differs from common IIO sysfs attribute
> conventions.
>
> Replace the non-standard frequencyY attribute documentation with
> out_altvoltageX_frequency and document tuning word selection
> through out_altvoltageX_frequencysymbol

Missing space?

> This makes the documented ABI naming consistent with standard
> IIO sysfs attribute conventions and clarifies how tuning word
> registers are selected and programmed.
>
>

(A single blank line is enough.)

> Signed-off-by: Abinash Singh <abinashlalotra@xxxxxxxxx>
> ---
>
> The out_altvoltageX_frequencysymbol and
> out_altvoltageX_frequency_scale attributes can be added
> through extended channel attributes (.ext_info in channel_spec struct of IIO)
>
> Feedback on this approach would be appreciated, and if
> there is some other way in your mind. I would like to
> work on that.
>
> I am also interested in working on the sysfs-bus-iio-dds
> documentation and the ad9834 driver. I recently bought an
> AD9833 IC for experimentation and testing.

I didn't get is the current documentation wrong or is it that currently
used ABI is wrong?

--
With Best Regards,
Andy Shevchenko