Re: [PATCH v2 04/10] iio: light: opt3001: use local struct device and i2c_client variables
From: Andy Shevchenko
Date: Tue May 12 2026 - 07:31:51 EST
On Tue, May 12, 2026 at 01:13:32PM +0200, Joshua Crofts wrote:
> On Tue, 12 May 2026 at 13:09, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, May 12, 2026 at 12:57:24PM +0200, Joshua Crofts via B4 Relay wrote:
> >
> > > Switch the driver to use local variables for struct device and struct
> > > i2c_client to improve code style.
> > >
> > > While at it, ensure that parentheses alignment is correct in functions
> > > that were changed in this patch.
> >
> > > No functional change.
> >
> > Right, but what I meant is to drop dev member from struct opt3001 completely
> > and derive it from client. Maybe it's done in the following patches? Haven't
>
> Ohhh, now I understand. Unfortunately you'll be disappointed, my patches don't
> deal with this...
No problem, you can do it in a followup (or next version, let's see how review
will go).
--
With Best Regards,
Andy Shevchenko