Re: [PATCH v8 v8 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text
From: Jonathan Cameron
Date: Tue May 12 2026 - 08:06:06 EST
On Mon, 11 May 2026 23:13:26 +0530
Piyush Patle <piyushpatle228@xxxxxxxxx> wrote:
> Rewrite the binding description and property text so it describes the
> existing HX711 hardware behavior directly instead of documenting old
> driver implementation details.
>
> Also clarify that clock-frequency controls the SCK bit-bang timing.
>
> No functional change.
>
> Signed-off-by: Piyush Patle <piyushpatle228@xxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
This is a good improvement on it's own so in the interests of moving
things along I'll apply this one now.
Applied to the testing branch of iio.git
Thanks,
Jonathan
> ---
> .../bindings/iio/adc/avia-hx711.yaml | 25 ++++++++-----------
> 1 file changed, 10 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> index 9c57eb13f892..1ea60dff98d5 100644
> --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> @@ -10,14 +10,9 @@ maintainers:
> - Andreas Klinger <ak@xxxxxxxxxxxxx>
>
> description: |
> - Bit-banging driver using two GPIOs:
> - - sck-gpio gives a clock to the sensor with 24 cycles for data retrieval
> - and up to 3 cycles for selection of the input channel and gain for the
> - next measurement
> - - dout-gpio is the sensor data the sensor responds to the clock
> -
> - Specifications about the driver can be found at:
> - http://www.aviaic.com/ENProducts.aspx
> + The HX711 is a 24-bit ADC with selectable gain (32/64/128) and two
> + differential input channels. Channel A supports gain 64 and 128;
> + channel B supports gain 32.
>
> properties:
> compatible:
> @@ -26,23 +21,23 @@ properties:
>
> sck-gpios:
> description:
> - Definition of the GPIO for the clock (output). In the datasheet it is
> - named PD_SCK
> + GPIO for the clock output (PD_SCK in the datasheet).
> maxItems: 1
>
> dout-gpios:
> description:
> - Definition of the GPIO for the data-out sent by the sensor in
> - response to the clock (input).
> - See Documentation/devicetree/bindings/gpio/gpio.txt for information
> - on how to specify a consumer gpio.
> + GPIO for the data output from the sensor (DOUT in the datasheet).
> maxItems: 1
>
> avdd-supply:
> description:
> - Definition of the regulator used as analog supply
> + Analog supply voltage (AVDD).
>
> clock-frequency:
> + description:
> + Controls the SCK bit-bang timing. The value is used to derive the
> + delay between SCK edges; keep the SCK high time below 60 us to
> + avoid triggering chip power-down mode.
> minimum: 20000
> maximum: 2500000
> default: 400000