Re: [PATCH for drm-misc-fixes v6 0/4] Fix some bugs in the hibmc driver

[Yongbang Shi]

> Hi,
> 
> I've gone through the series and reviewed the patches. Let me know when they are ready to get merged.
>

Thanks for the review. The series is ready for merging now.

Thanks,
Yongbang.


> Best regards
> Thomas
> 
> 
> Am 09.05.26 um 05:22 schrieb Yongbang Shi:
>> From: Lin He <helin52@xxxxxxxxxx>
>>
>> There are some bugfix for hibmc-drm driver.
>>
>> ---
>> ChangeLog:
>> v5 -> v6:
>>    - Rename 'phys_state' to 'phys_status'
>>    - Replace `drm_kms_helper_poll_init` with `drmm_kms_helper_poll_init`
>>      and adjust the timing of the call.
>>    - Split "return vdac->phys_state = state;" into separate statements.
>>    - Change `get_mode` to return 0 when no modes are available, allowing DRM to
>>      install a default resolution.
>>    - Change the initial phys_status of vdac from
>>      'connector_status_connected' to 'connector_status_disconnected'
>>    - Removed invalid bit configurations from `hibmc_display_ctrl`.
>>    - Modify the return values of `hibmc_get_best_clock_idx` and
>>      `hibmc_crtc_mode_valid`
>> v4 -> v5:
>>    - The 'epoch_counter' of the vdac connector is incremented when the
>>     physical status changes.
>>    - The polling mechanism for the KMS helper is enabled.
>> v3 -> v4:
>>    - fix incorrect cover-letter subject prefix in v3.
>> v2 -> v3:
>>    - remove unused macro CLOCK_TOLERANCE.
>> v1 -> v2:
>>    - fix the checkpatch.pl warning "Unknown commit ID 'e6c7c59da494'".
>>    - fix the checkpatch.pl warning "line length of 83/85 exceeds 80 columns".
>>    - remove tag "Reviewed-by: Tao Tian <tiantao6@xxxxxxxxxxxxx>", witch will
>>      be given in public.
>>    - add 'drm-misc-fixes' in subject prefix.
>> ---
>>
>> Lin He (4):
>>    drm/hisilicon/hibmc: add updating link cap in DP detect()
>>    drm/hisilicon/hibmc: fix no showing when no connectors connected
>>    drm/hisilicon/hibmc: move display contrl config to hibmc_probe()
>>    drm/hisilicon/hibmc: use clock to look up the PLL value
>>
>>   drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h  |  1 +
>>   drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h    |  1 +
>>   drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c  |  2 +-
>>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c    | 80 +++++++++++--------
>>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c    | 35 +++++---
>>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   | 14 ++++
>>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h   |  1 +
>>   .../gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c  | 75 +++++++++--------
>>   8 files changed, 124 insertions(+), 85 deletions(-)
>>
>