Re: [PATCH 2/3] iio: adc: sun20i-gpadc: add A523 gpadc support

[Andre Przywara]

Hi,

On 5/12/26 13:51, Jonathan Cameron wrote:
> On Sun, 10 May 2026 14:57:23 +0200
> Michal Piekos <michal.piekos@xxxxxxxxxxxxx> wrote:
>
> > A523 differs from existing sun20i-gpadc-iio by having two clocks; bus
> > clock and module clock.
> >
> > Change driver to enable all clocks.
> >
> > Signed-off-by: Michal Piekos <michal.piekos@xxxxxxxxxxxxx>
> I'm expecting this to change given comment on not being quite compatible so
> I'll wait for v2 before reviewing.

Yes, we need a v2, but just for adding the new compatible string. 
Otherwise I think this patch is a neat solution, because we don't need 
to further differentiate between the different SoC's number of required 
clocks.

Cheers,
Andre

> Thanks,
>
> Jonathan
>
> > ---
> >   drivers/iio/adc/sun20i-gpadc-iio.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/iio/adc/sun20i-gpadc-iio.c b/drivers/iio/adc/sun20i-gpadc-iio.c
> > index 861c14da75ad..dd4c7e6e3d76 100644
> > --- a/drivers/iio/adc/sun20i-gpadc-iio.c
> > +++ b/drivers/iio/adc/sun20i-gpadc-iio.c
> > @@ -180,7 +180,7 @@ static int sun20i_gpadc_probe(struct platform_device *pdev)
> >   	struct iio_dev *indio_dev;
> >   	struct sun20i_gpadc_iio *info;
> >   	struct reset_control *rst;
> > -	struct clk *clk;
> > +	struct clk_bulk_data *clks;
> >   	int irq;
> >   	int ret;
> >   
> > @@ -205,9 +205,9 @@ static int sun20i_gpadc_probe(struct platform_device *pdev)
> >   	if (IS_ERR(info->regs))
> >   		return PTR_ERR(info->regs);
> >   
> > -	clk = devm_clk_get_enabled(dev, NULL);
> > -	if (IS_ERR(clk))
> > -		return dev_err_probe(dev, PTR_ERR(clk), "failed to enable bus clock\n");
> > +	ret = devm_clk_bulk_get_all_enabled(dev, &clks);
> > +	if (ret < 0)
> > +		return dev_err_probe(dev, ret, "failed to enable clocks\n");
> >   
> >   	rst = devm_reset_control_get_exclusive(dev, NULL);
> >   	if (IS_ERR(rst))