Re: [PATCH v1 1/2] iio: Drop unused driver_data in four i2c drivers

[Jonathan Cameron]

On Tue, 12 May 2026 14:50:34 +0200
Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx> wrote:

> For the four drivers the .driver_data member of i2c_device_id is
> write-only. Drop the explicit assignment.
> 
> While touching these arrays use a named initializer to assign the .name
> member, which is easier to parse for a human.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>

Given these are obviously a good idea and the other cases I called out
are more complex so probably want their own patches...

Applied to the testing branch of iio.git

Thanks

Jonathan

> ---
>  drivers/iio/adc/pac1921.c    | 2 +-
>  drivers/iio/light/apds9160.c | 2 +-
>  drivers/iio/light/tsl2563.c  | 8 ++++----
>  drivers/iio/light/tsl2583.c  | 6 +++---
>  4 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/iio/adc/pac1921.c b/drivers/iio/adc/pac1921.c
> index bce7185953ec..68bdd2f30bad 100644
> --- a/drivers/iio/adc/pac1921.c
> +++ b/drivers/iio/adc/pac1921.c
> @@ -1310,7 +1310,7 @@ static int pac1921_probe(struct i2c_client *client)
>  }
>  
>  static const struct i2c_device_id pac1921_id[] = {
> -	{ .name = "pac1921", 0 },
> +	{ .name = "pac1921" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, pac1921_id);
> diff --git a/drivers/iio/light/apds9160.c b/drivers/iio/light/apds9160.c
> index 3da0bdac04cf..8dacb1730429 100644
> --- a/drivers/iio/light/apds9160.c
> +++ b/drivers/iio/light/apds9160.c
> @@ -1572,7 +1572,7 @@ static const struct of_device_id apds9160_of_match[] = {
>  MODULE_DEVICE_TABLE(of, apds9160_of_match);
>  
>  static const struct i2c_device_id apds9160_id[] = {
> -	{ "apds9160", 0 },
> +	{ .name = "apds9160" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, apds9160_id);
> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
> index f2af1cd7c2d1..7e277bc6a8b1 100644
> --- a/drivers/iio/light/tsl2563.c
> +++ b/drivers/iio/light/tsl2563.c
> @@ -839,10 +839,10 @@ static DEFINE_SIMPLE_DEV_PM_OPS(tsl2563_pm_ops, tsl2563_suspend,
>  				tsl2563_resume);
>  
>  static const struct i2c_device_id tsl2563_id[] = {
> -	{ "tsl2560", 0 },
> -	{ "tsl2561", 1 },
> -	{ "tsl2562", 2 },
> -	{ "tsl2563", 3 },
> +	{ .name = "tsl2560" },
> +	{ .name = "tsl2561" },
> +	{ .name = "tsl2562" },
> +	{ .name = "tsl2563" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, tsl2563_id);
> diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
> index 8801a491de77..a0dd122af2cf 100644
> --- a/drivers/iio/light/tsl2583.c
> +++ b/drivers/iio/light/tsl2583.c
> @@ -913,9 +913,9 @@ static DEFINE_RUNTIME_DEV_PM_OPS(tsl2583_pm_ops, tsl2583_suspend,
>  				 tsl2583_resume, NULL);
>  
>  static const struct i2c_device_id tsl2583_idtable[] = {
> -	{ "tsl2580", 0 },
> -	{ "tsl2581", 1 },
> -	{ "tsl2583", 2 },
> +	{ .name = "tsl2580" },
> +	{ .name = "tsl2581" },
> +	{ .name = "tsl2583" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, tsl2583_idtable);