Re: [PATCH v2 05/16] iio: adc: mediatek: add mt6323 PMIC AUXADC driver

[Roman Vivchar]

On Tuesday, May 12th, 2026 at 4:29 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Tue, 12 May 2026 08:18:19 +0300
> Roman Vivchar via B4 Relay <devnull+rva333.protonmail.com@xxxxxxxxxx> wrote:

...

> > +#define VOLTAGE_FULL_RANGE	1800
> Probably better to have this inline - however if you do keep it
> prefix t he define  VOLTAGE_FULL_RANGE sounds too generic!
> 
> > +#define AUXADC_PRECISE		32768
> I'd put that inline.  Little benefit it in having it up here...

There was a mention about magic values in the v1 for the thermal patch [1].
Andy, would it be better to use an inline style or a #define here?
If the former, I'll rename the first constant to something like
AUXADC_VOLTAGE_FULL_RANGE.

[1]: https://lore.kernel.org/linux-mediatek/afmnUG8dG0N0HpV6@ashevche-desk.local/

Best regards,
Roman